[PATCH] D143225: [SROA] Create additional vector type candidates based on store and load slices

[Mingming Liu via Phabricator via llvm-commits]

mingmingl added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/SROA.cpp:1952-1959
+    LoadStoreTys.insert(Ty);
+    // Consider any loads or stores that are the exact size of the slice.
+    if (S.beginOffset() == P.beginOffset() && S.endOffset() == P.endOffset())
+      CheckCandidateType(Ty);
+  }
+  // Consider additional vector types where the element type size is a
+  // multiple of load/store element size.
----------------
(Take the liberty to chime in for my understanding)
Here `Ty` is inserted even if it doesn't have the exact size with `P`. Does it mean (in this patch) that slices (`S`) are considered for vector SROA even if it has different size than `P`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143225/new/

https://reviews.llvm.org/D143225