[PATCH] D142507: [AMDGPU] Split dot7 feature

Tue Feb 14 12:26:20 PST 2023

rampitec added a comment.

In D142507#4126864 <https://reviews.llvm.org/D142507#4126864>, @aaronmondal wrote:

>> It shall be complimented by the device-lib change in the corresponding release, so it is not that simple.
>
> @rampitec I'm not sure I understand. Does this mean that this is breaking in a way that Clang 17 won't be able to build ROCm 5.4?
>
> I thought it was like "we need D142507 <https://reviews.llvm.org/D142507> to build device-libs after 8dc779e <https://github.com/RadeonOpenCompute/ROCm-Device-Libs/commit/8dc779e19cbf2ccfd3307b60f7db57cf4203a5be>" and for older device libs we just fall back to some older behavior.

Since the feature is actually used by the device-lib it had to be updated in lock step with the compiler change, not after or before. That's what was done in the downstream.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142507/new/

https://reviews.llvm.org/D142507