[PATCH] D143981: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D143981#4126218 <https://reviews.llvm.org/D143981#4126218>, @akyrtzi wrote:

> In D143981#4125246 <https://reviews.llvm.org/D143981#4125246>, @jbms wrote:
>
>> The MSVC ".asm" files aren't preprocessed, though.
>
> Good point, for now let's use `#define`s for `.S` files and rename inline for the `.asm` files; later on we could consider setting up manual preprocessing via CMake for the `.asm` files as well.
> Essentially my suggestion is to pull the renaming `#define`s out of `blake3_impl.h` and into a separate file, then have it included from `blake3_impl.h` and the `.S` files. The `.asm` files get renames inline for now.

This plan looks good to me. I am fine with changing `.asm` files. If we use a CMake approach, gn and bazel (unsupported build systems) users need to port this logic as well...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143981/new/

https://reviews.llvm.org/D143981