[PATCH] D143505: [InstSimplify] fix/improve folding with an SNaN operand

[James Y Knight via Phabricator via llvm-commits]

jyknight accepted this revision.
jyknight added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5320
       // Replace unknown or undef elements with canonical NaN.
+      // TODO: Quiet a signaling NaN element.
       if (EltC && (isa<PoisonValue>(EltC) || EltC->isNaN()))
----------------
spatel wrote:
> jyknight wrote:
> > Why is this a TODO? Is it more complex than just another call to makeQuiet?
> I don't think so. It was just to have a minimal patch as a first step (the APFloat change wasn't in this patch in the first draft either). 
> 
> I can add vector tests and make that a follow-up patch, or I can squash it all together if that's preferred.
If you're sending a follow-up to fix this, too, then SGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143505/new/

https://reviews.llvm.org/D143505