[PATCH] D144009: [obj2yaml] Save offset for segments and size for PHDR

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 10:50:02 PST 2023


MaskRay added a comment.

In D144009#4126247 <https://reviews.llvm.org/D144009#4126247>, @treapster wrote:

> Only save offset for the first segment for now to fix tests. But changing tests and saving all offsets is probably better?

Just show what the complete fix is, then update all the tests (usually for obj2yaml there are not many to update).

If you feel that the change may need several iterations and don't want to modify tests back and forth, you can say that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144009/new/

https://reviews.llvm.org/D144009



More information about the llvm-commits mailing list