[PATCH] D143505: [InstSimplify] fix/improve folding with an SNaN operand

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 09:46:15 PST 2023


jyknight added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5320
       // Replace unknown or undef elements with canonical NaN.
+      // TODO: Quiet a signaling NaN element.
       if (EltC && (isa<PoisonValue>(EltC) || EltC->isNaN()))
----------------
Why is this a TODO? Is it more complex than just another call to makeQuiet?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143505/new/

https://reviews.llvm.org/D143505



More information about the llvm-commits mailing list