[PATCH] D144017: [Support] Make LLVM_EXTERNAL_VISIBILITY meaningful on Windows

Jun Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 09:33:56 PST 2023


junaire updated this revision to Diff 497364.
junaire added a comment.

Fix the build failure


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144017/new/

https://reviews.llvm.org/D144017

Files:
  llvm/include/llvm/Support/Compiler.h


Index: llvm/include/llvm/Support/Compiler.h
===================================================================
--- llvm/include/llvm/Support/Compiler.h
+++ llvm/include/llvm/Support/Compiler.h
@@ -123,9 +123,13 @@
 #define LLVM_EXTERNAL_VISIBILITY
 #endif
 #else
-#define LLVM_LIBRARY_VISIBILITY
+#if defined(_WIN32)
+#define LLVM_EXTERNAL_VISIBILITY __declspec(dllexport)
+#esle
 #define LLVM_EXTERNAL_VISIBILITY
 #endif
+#define LLVM_LIBRARY_VISIBILITY
+#endif
 
 #if defined(__GNUC__)
 #define LLVM_PREFETCH(addr, rw, locality) __builtin_prefetch(addr, rw, locality)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144017.497364.patch
Type: text/x-patch
Size: 571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230214/e07d4dcf/attachment.bin>


More information about the llvm-commits mailing list