[PATCH] D143981: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions

Argyrios Kyrtzidis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 08:18:10 PST 2023


akyrtzi added a comment.

In D143981#4125246 <https://reviews.llvm.org/D143981#4125246>, @jbms wrote:

> The MSVC ".asm" files aren't preprocessed, though.

Good point, for now let's use `#define`s for `.S` files and rename inline for the `.asm` files; later on we could consider setting up manual preprocessing via CMake for the `.asm` files as well.
Essentially my suggestion is to pull the renaming `#define`s out of `blake3_impl.h` and into a separate file, then have it included from `blake3_impl.h` and the `.S` files. The `.asm` files get renames inline for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143981/new/

https://reviews.llvm.org/D143981



More information about the llvm-commits mailing list