[PATCH] D143316: [m68k] Implement absolution long addressing mode for ADDA instruction

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 04:33:05 PST 2023


0x59616e updated this revision to Diff 497271.
0x59616e added a comment.

- Add disassembler test
- Move assembler test into MxBiArOp_RFRM.s


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143316/new/

https://reviews.llvm.org/D143316

Files:
  llvm/lib/Target/M68k/M68kInstrArithmetic.td
  llvm/test/MC/Disassembler/M68k/arithmetic.txt
  llvm/test/MC/M68k/Arith/Classes/MxBiArOp_RFRM.s


Index: llvm/test/MC/M68k/Arith/Classes/MxBiArOp_RFRM.s
===================================================================
--- llvm/test/MC/M68k/Arith/Classes/MxBiArOp_RFRM.s
+++ llvm/test/MC/M68k/Arith/Classes/MxBiArOp_RFRM.s
@@ -67,3 +67,6 @@
 ; CHECK:      adda.l  (%a1), %a3
 ; CHECK-SAME: encoding: [0xd7,0xd1]
 adda.l	(%a1), %a3
+; CHECK: adda.l dst, %a0
+; CHECK-SAME: encoding: [0xd1,0xf9,A,A,A,A]
+adda.l dst,%a0
Index: llvm/test/MC/Disassembler/M68k/arithmetic.txt
===================================================================
--- llvm/test/MC/Disassembler/M68k/arithmetic.txt
+++ llvm/test/MC/Disassembler/M68k/arithmetic.txt
@@ -214,3 +214,6 @@
 
 # CHECK: or.l %d1, %d6
 0x8c 0x81
+
+# CHECK: adda.l  $f0001, %a0
+0xd1 0xf9 0x00 0x0f 0x00 0x01
Index: llvm/lib/Target/M68k/M68kInstrArithmetic.td
===================================================================
--- llvm/lib/Target/M68k/M68kInstrArithmetic.td
+++ llvm/lib/Target/M68k/M68kInstrArithmetic.td
@@ -293,6 +293,8 @@
                                   CMD, MxEncAddrMode_p<"opd">>;
   def NAME#"32aj" : MxBiArOp_R_RM<MN, NODE, MxType32a, MxType32.JOp, MxType32.JPat,
                                   CMD, MxEncAddrMode_j<"opd">>;
+  def NAME#"32ab" : MxBiArOp_R_RM<MN, NODE, MxType32a, MxType32.BOp, MxType32.BPat,
+                                  CMD, MxEncAddrMode_abs<"opd", true>>;
   def NAME#"32ai" : MxBiArOp_R_RI_xEA<MN, NODE, MxType32a, CMD>;
 
   def NAME#"32ar" : MxBiArOp_R_RR_xEA<MN, NODE, MxType32a, MxType32r, CMD>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143316.497271.patch
Type: text/x-patch
Size: 1516 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230214/deb14d1d/attachment.bin>


More information about the llvm-commits mailing list