[PATCH] D143892: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/addr-sink-call-multi-arg.ll:1
+; RUN: llc --stop-after=codegenprepare < %s | FileCheck %s
+
----------------
Can we make this an `opt -codegenprepare` test instead and use update_test_checks? (Applies to the rest of this patch stack as well.)


================
Comment at: llvm/test/CodeGen/Generic/addr-sink-call-multi-arg.ll:7
+entry:
+    %a0 = getelementptr i32 *, ptr %p, i32 %i
+    %a1 = getelementptr i32 *, ptr %p, i32 4
----------------
`i32 *` should be `ptr` as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143892/new/

https://reviews.llvm.org/D143892