[PATCH] D143998: [GISel] Fix types of operands of G_INDEXED_*

RĂ©mi SEGARD via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 03:16:17 PST 2023


RemiSEGARD created this revision.
Herald added a subscriber: arphaman.
Herald added a project: All.
RemiSEGARD requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The last operand of these instructions was "unknown", when writing
patterns for them. It ends up testing the type of the operand but it
would always fail as that operand is supposed to be an immediate inside
the instruction.
Moreover, G_INDEXED_STORE had a ptype as its offset type, it makes it
incorrect and prevents correct pattern checking to be generated as it
would be checking for a pointer on its offset operand.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143998

Files:
  llvm/include/llvm/Target/GenericOpcodes.td
  llvm/test/TableGen/GlobalISelEmitterIndexed.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143998.497262.patch
Type: text/x-patch
Size: 11065 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230214/e14532f7/attachment-0001.bin>


More information about the llvm-commits mailing list