[PATCH] D143945: [AMDGPU] Add legalization case for PTR_ADD on buffer pointers
Piotr Sobczak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 14 00:40:10 PST 2023
piotr added subscribers: nhaehnle, piotr.
piotr added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.h:382
+
+ BUFFER_FAT_POINTER = 7, ///< Address space for 128-bit buffer fat pointers.
+
----------------
This is now in conflict with the description in AMDGPUUsage.rst, which says 160-bit.
In fact, making it 160-bit (including offset) was a deliberate choice, see discussion in https://reviews.llvm.org/D58957?id=189289#inline-522534. But perhaps now it's good time to revisit the discussion, fyi @nhaehnle.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143945/new/
https://reviews.llvm.org/D143945
More information about the llvm-commits
mailing list