[PATCH] D134599: [RISCV] Add CodeGen support of RISCV zcmp Extension

[KaiYi via Phabricator via llvm-commits]

KYG added inline comments.
Herald added a subscriber: luke.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:268
+    Register Reg = Entry.getReg();
+    if (!(Reg == RISCV::X26 || RISCV::PGPRRegClass.contains(Reg))) {
+      NonePushStackOffset -= MFI.getObjectSize(Entry.getFrameIdx());
----------------
Seems like the `def PGPR : RegisterClass ...` is missed in RISCVRegisterInfo.td?





================
Comment at: llvm/lib/Target/RISCV/RISCVPushPopOptimizer.cpp:105
+    MachineInstr &MI = *I;
+    if (auto OperandPair = TII->isLoadImmImpl(MI)) {
+      Register DestReg = OperandPair->Destination->getReg();
----------------
Um...where is the implementation of this function? (Or use `isCopyInstrImpl()` instead?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134599/new/

https://reviews.llvm.org/D134599