[PATCH] D143981: [Support/BLAKE3] Rename blake3_* -> llvm_blake3_* to avoid symbol collisions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 22:56:24 PST 2023


MaskRay added a comment.

LGTM in spirit, it matches `blake3.c` and other libraries (e.g. `Support/regexec.c`?) How do you verify that all blake3 non-local symbols are now prefixed?
I think this is a good candidate for the `release/16.x` branch (https://github.com/llvm/llvm-project/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22LLVM+16.0.0+Release%22)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143981/new/

https://reviews.llvm.org/D143981



More information about the llvm-commits mailing list