[PATCH] D143981: Rename blake3_* -> llvm_blake3_* to avoid symbol collisions

Jeremy Maitin-Shepard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 22:35:49 PST 2023


jbms created this revision.
jbms added a reviewer: akyrtzi.
Herald added a subscriber: hiraditya.
Herald added a project: All.
jbms requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

While some blake3 symbols are already prefixed, a number of symbols with hidden visibility have been left without an `llvm_` prefix.  This results in symbol collisions when statically linking llvm into a binary that also uses the external blake3 library.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143981

Files:
  llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_unix.S
  llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
  llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_msvc.asm
  llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_unix.S
  llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
  llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_msvc.asm
  llvm/lib/Support/BLAKE3/blake3_impl.h
  llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_unix.S
  llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
  llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_msvc.asm
  llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_unix.S
  llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
  llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_msvc.asm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143981.497210.patch
Type: text/x-patch
Size: 21675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230214/fb2dfa65/attachment.bin>


More information about the llvm-commits mailing list