[PATCH] D141560: [RISCV][CodeGen] Add codegen pattern for experimental zfa extension

Mon Feb 13 22:19:29 PST 2023

joshua-arch1 added a comment.

In D141560#4124967 <https://reviews.llvm.org/D141560#4124967>, @craig.topper wrote:

> In D141560#4124863 <https://reviews.llvm.org/D141560#4124863>, @joshua-arch1 wrote:
>
>> In D141560#4122948 <https://reviews.llvm.org/D141560#4122948>, @reames wrote:
>>
>>> In D141560#4120971 <https://reviews.llvm.org/D141560#4120971>, @joshua-arch1 wrote:
>>>
>>>> Since the assmebly support patch for Zfa instructions except FLI has been accepted, could anyone please review this codegen patch?
>>>
>>> I'd encourage you to land the underlying approved review.  I can't speak for others, but I certainty prioritize review for changes which have fewer outstanding blocking issues.  You could also split this into an FLI and non-FLI part with the same reasoning.
>>
>> Different from assembly support, I think there is nothing special with the codegen pattern for FLI instruction. It's unnecessory to split the codegen patch into an FLI and non-FLI part.
>
> The suggestion to split is to unblock parts of the patch. We would rather have small pieces make progress than stalling a whole patch when one part of it that can be isolated needs additional work. Smaller patches are much easier to review and re-review.

I see. I will split these patch into three small ones. One for FLI, one for FCVMOD and another for other instructions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141560/new/

https://reviews.llvm.org/D141560