[PATCH] D142803: [ComplexLogicCombine 1/?] Implement a general way to simplify complex logical operations.

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 18:42:33 PST 2023


bcl5980 added a comment.

In D142803#4124135 <https://reviews.llvm.org/D142803#4124135>, @spatel wrote:

> I'm still trying to understand how this works, so I only looked at the high-level comments to start.
>
> Is it possible to convert existing logic tests in InstCombien/InstSimplify to use branches, then run those tests with "opt -aggressive-instcombine" and verify that the results are correct?

I'm not sure if it is possible, but if we want to test more cases I can try to add an option to make it work on every logical operations. And I can run local to test but I'm not sure how to show the result on the review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142803/new/

https://reviews.llvm.org/D142803



More information about the llvm-commits mailing list