[PATCH] D143942: [NFC] Replace -1U{LL} expressions with appropriate *_MAX macros in Support library.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 13 13:25:49 PST 2023
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Mixed feelings - if the code is valid/does what the developer intended, and the MSVC warning is just giving false positives/being too chatty, then we should probably disable the MSVC warning.
Equally, this does seem more readable, at the cost of including another header - but I guess there aren't too many TUs that don't include climits somewhere along the way.
I'm OK with this, but also open to hearing other people's perspectives.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143942/new/
https://reviews.llvm.org/D143942
More information about the llvm-commits
mailing list