[PATCH] D142015: [LV] Plan with and without FoldTailByMasking

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 12:18:26 PST 2023


fhahn added a comment.

In D142015#4114045 <https://reviews.llvm.org/D142015#4114045>, @fhahn wrote:

> I agree that we shouldn't have a new hierarchies containing multiple plans. IIUC this is referring to D142669 <https://reviews.llvm.org/D142669> where it picks selects the list of plans for the most profitable VF returned by `plan`. This was mostly to keep the sketch of supporting multiple cost models simple (in terms of time to implement).  I *think* this could be improved by computing the cost for each plan directly, instead of doing so after constructing all plans in `selectVectorizationFactor`. I'll try to see if there are any stumbling blocks down this path.

Sketched in D143938 <https://reviews.llvm.org/D143938> and updated D142669 <https://reviews.llvm.org/D142669>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142015/new/

https://reviews.llvm.org/D142015



More information about the llvm-commits mailing list