[PATCH] D143934: [AMDGPU] Do not apply schedule metric for regions with spilling

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 12:12:30 PST 2023


rampitec added a comment.

In D143934#4123865 <https://reviews.llvm.org/D143934#4123865>, @arsenm wrote:

> testcase?

This is tough. These tests are huge and largely unsound, and here we are talking about a border case which can be easily shifted towards producing no spilling because of earlier stages, or no spilling because of the change in the metric itself, not because of this line of code. I am generally not convinced in usefulness of scheduling lit tests, they take a lot of time but deteriorate quickly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143934/new/

https://reviews.llvm.org/D143934



More information about the llvm-commits mailing list