[PATCH] D143542: [SeparateConstOffsetFromGEP] Fix: `b - a` matched `a - b` during reuniteExts

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Please upload with more context - use something like "git diff -U9999".



================
Comment at: llvm/test/Transforms/SeparateConstOffsetFromGEP/AArch64/split-gep-sub.ll:1
+; RUN: llc --mtriple aarch64-unknown-linux -O3 -aarch64-enable-gep-opt \
+; RUN:   -start-before=separate-const-offset-from-gep \
----------------
It would be better to use a RUN line with `opt` like existing tests in this and the parent directory.
IIUC, we have a miscompile, so you can create a baseline test that shows the bug, commit that to main, and then regenerate the CHECK lines with this patch, so we show the difference in IR. Please use "utils/update_test_checks.py" to auto-generate the CHECK lines instead of manually writing them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143542/new/

https://reviews.llvm.org/D143542