[PATCH] D143793: Add the ability to segment GSYM files.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 06:51:14 PST 2023


avl added inline comments.


================
Comment at: llvm/lib/DebugInfo/GSYM/FunctionInfo.cpp:126
+  if (!EncodingCache.empty() &&
+      support::endian::system_endianness() == O.getByteOrder()) {
+    // We already encoded this object, just write out the bytes.
----------------
probably, name it a bit more descriptive?


================
Comment at: llvm/lib/DebugInfo/GSYM/GsymCreator.cpp:449
+uint64_t GsymCreator::calculateHeaderAndTableSize() const {
+  uint64_t size = sizeof(Header);
+  const size_t NumFuncs = Funcs.size();
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143793/new/

https://reviews.llvm.org/D143793



More information about the llvm-commits mailing list