[PATCH] D143707: [AMDGPU] Allow architected SGPRs for workgroup IDs

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:2193
     // not really be added.
-    unsigned NumRequiredSystemSGPRs = Info.hasWorkGroupIDX() +
-                                      Info.hasWorkGroupIDY() +
-                                      Info.hasWorkGroupIDZ() +
-                                      Info.hasWorkGroupInfo();
+    unsigned NumSystemSGPRsForWorkGroupIDs =
+        HasArchitectedSGPRs ? 0
----------------
It is not at all clear how hasArchitectedSGPRs and hasUserSGPRInit16Bug should interact. Instead of guessing, how about asserting !HasArchitectedSGPRs here unless/until there is an ASIC that has both features?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143707/new/

https://reviews.llvm.org/D143707