[PATCH] D142084: [RFC][X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

[Bing Yu via Phabricator via llvm-commits]

yubing added inline comments.


================
Comment at: llvm/lib/Target/X86/X86MemFoldTables.inc:509-510
   {X86::MMX_CVTTPS2PIrr, X86::MMX_CVTTPS2PIrm, TB_NO_REVERSE},
+  {X86::MMX_MOVD64rr, X86::MMX_MOVD64rm, 0},
   {X86::MMX_MOVD64to64rr, X86::MMX_MOVQ64rm, 0},
+  {X86::MMX_MOVQ64rr, X86::MMX_MOVQ64rm, 0},
----------------
should remove one of them otherwise leads to duplicate entry in unfolding table.
i will remove {X86::MMX_MOVQ64rr, X86::MMX_MOVQ64rm, 0}, and write "{X86::MMX_MOVQ64rr, X86::MMX_MOVQ64rm, noforward || noreverse}," in llvm/utils/TableGen/X86FoldTablesEmitterManualMapSet.inc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084