[PATCH] D143838: [X86] Improve (select carry C1+1 C1)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 12 02:37:40 PST 2023


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:49895
+                                         SelectionDAG &DAG,
+                                         bool ZeroSecondOpOnly = false);
+
----------------
Instead of adding a forward declaration - could we not just move the 2 existing combineAddOrSubToADCOrSBB implementations up here as a NFC?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143838/new/

https://reviews.llvm.org/D143838



More information about the llvm-commits mailing list