[PATCH] D143793: Add the ability to segment GSYM files.

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/GSYM/GsymCreator.h:141
+  // Needed for mapping string offsets back to the string stored in \a StrTab.
+  DenseMap<uint32_t, CachedHashStringRef> StringOffsetMap;
   std::vector<llvm::gsym::FileEntry> Files;
----------------
Maybe make it 64bit to future proof?


================
Comment at: llvm/lib/DebugInfo/GSYM/GsymCreator.cpp:93
+  // Base address must be valid if we have functions.
+  assert(BaseAddress);
+
----------------
Maybe return an error like below? In case this is built with asserts disabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143793/new/

https://reviews.llvm.org/D143793