[PATCH] D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 04:30:56 PST 2023


CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVStringPool.h:38-39
   LVStringPool() { getIndex(""); }
-  LVStringPool(LVStringPool const &other) = delete;
-  LVStringPool(LVStringPool &&other) = delete;
+  LVStringPool(LVStringPool const &Other) = delete;
+  LVStringPool(LVStringPool &&Other) = delete;
   ~LVStringPool() = default;
----------------
jmorse wrote:
> Best not to include unrelated NFC changes as it can be a review burden,
Good point. I will remove it from the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143716/new/

https://reviews.llvm.org/D143716



More information about the llvm-commits mailing list