[PATCH] D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64.

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

If I understand correctly, this is moving the tool-global string pool from a header-function into something with one-definition -- definitely the right direction to take. I think Orlando might have said that a context-object-with-string-pool is probably the best overall solution, but this is a good improvement for now.



================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVStringPool.h:38-39
   LVStringPool() { getIndex(""); }
-  LVStringPool(LVStringPool const &other) = delete;
-  LVStringPool(LVStringPool &&other) = delete;
+  LVStringPool(LVStringPool const &Other) = delete;
+  LVStringPool(LVStringPool &&Other) = delete;
   ~LVStringPool() = default;
----------------
Best not to include unrelated NFC changes as it can be a review burden,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143716/new/

https://reviews.llvm.org/D143716