[PATCH] D143678: [bazel] Add layering-check on CI

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet reclaimed this revision.
gchatelet added a comment.

In D143678#4117090 <https://reviews.llvm.org/D143678#4117090>, @rupprecht wrote:

> In D143678#4116440 <https://reviews.llvm.org/D143678#4116440>, @gchatelet wrote:
>
>> I just looked at the premerge checks and I can see how this will be hard to fix globally (if at all possible).
>> I'll use the package feature instead.
>
> IMO we should try to clean those up, and then once we do so, remove the package-level annotations and have the feature globally enabled -- but as `build --features=layering_check`, not `build:ci --features=layering_check`.
>
> If there are any that are really problematic, we can add a feature to disable layering check for that rule (or package)

I've fixed all layering checks in https://github.com/llvm/llvm-project/commit/1842b5885baa1e002b3fa8b6ac1bae9cf4d39610
I'm reviving this patch to add `build --features=layering_check` as you suggests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143678/new/

https://reviews.llvm.org/D143678