[PATCH] D143678: [bazel] Add layering-check on CI
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 9 19:13:15 PST 2023
rupprecht added a comment.
In D143678#4116440 <https://reviews.llvm.org/D143678#4116440>, @gchatelet wrote:
> I just looked at the premerge checks and I can see how this will be hard to fix globally (if at all possible).
> I'll use the package feature instead.
IMO we should try to clean those up, and then once we do so, remove the package-level annotations and have the feature globally enabled -- but as `build --features=layering_check`, not `build:ci --features=layering_check`.
If there are any that are really problematic, we can add a feature to disable layering check for that rule (or package)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143678/new/
https://reviews.llvm.org/D143678
More information about the llvm-commits
mailing list