[PATCH] D143648: [AMDGPU][GlobalISel] Fix selection of image sample g16 instructions

Mirko Brkusanin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 07:04:45 PST 2023


mbrkusanin created this revision.
mbrkusanin added reviewers: foad, arsenm.
mbrkusanin added a project: LLVM.
Herald added subscribers: kosarev, StephenFan, wenlei, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
mbrkusanin requested review of this revision.
Herald added a subscriber: wdng.

Pre-GFX10 A16 modifier would imply G16. From GFX10 and onward there are
separate instructions for 16bit gradients. This fixes the condition for
selecting G16 opcodes. Also stop adding G16 flag to instructions that do not
use gradients for GFX10 onward.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143648

Files:
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.atomic.dim.a16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.dim.a16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.sample.a16.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.image.sample.g16.a16.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.g16.a16.dim.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143648.496115.patch
Type: text/x-patch
Size: 138690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230209/f281edd8/attachment-0001.bin>


More information about the llvm-commits mailing list