[PATCH] D139298: WIP: Add error handling to demangle API

[Tobias Hieta via Phabricator via llvm-commits]

thieta added inline comments.


================
Comment at: llvm/include/llvm/Demangle/Demangle.h:53
+    case llvm::DemangleError::Success:
+      return "success.";
+    }
----------------
thieta wrote:
> jhenderson wrote:
> > Nit: capitalization here is inconsistent.
> > 
> > FWIW, the LLVM coding standards state for warning and error messages to a) start with a lower case letter, and b) not to end with a period. Whether that applies in this context is debatable.
> Hmm seems like it should apply here, I will make it consistent.
I missed this - but will fix in the next revision of the patch.


================
Comment at: llvm/tools/llvm-undname/llvm-undname.cpp:80
       microsoftDemangle(S.c_str(), &NRead, nullptr, nullptr, &Status, Flags);
-  if (Status == llvm::demangle_success) {
+  if (Status == 0) {
     outs() << ResultBuf << "\n";
----------------
just a temp change until I do the microsoftDemangle api.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139298/new/

https://reviews.llvm.org/D139298