[PATCH] D139298: WIP: Add error handling to demangle API

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 02:35:20 PST 2023


thieta added a comment.

Hi - I finally got around to picking this one up again. This is rebased, passing all tests and now we pass the std::error_code directly to the API and changed all the callers to `itaniumDemangle()` and changed most of the places to actually check the error_code instead of the return `const char*`.

What do you guys think about this API change? If we like this in general, I can start changing the other demangle calls, either as part of this diff or in separate diffs per demangle API.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139298/new/

https://reviews.llvm.org/D139298



More information about the llvm-commits mailing list