[PATCH] D142219: [MC] Store operand info immediately after the TargetInsts table. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 02:36:32 PST 2023


foad added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstrDesc.h:577
   ArrayRef<MCPhysReg> implicit_defs() const {
     auto ImplicitOps = reinterpret_cast<const MCPhysReg *>(this + Opcode + 1);
     return {ImplicitOps + ImplicitOffset + NumImplicitUses, NumImplicitDefs};
----------------
barannikov88 wrote:
> ImplicitOps -> OpInfo (this is where it points now)
> 
> 
You're right that it points to the start of the OpInfo, but I'm not sure that's important. It's also the "origin" from which implicit op list offsets are measured. So maybe `ImplicitOpOrigin`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142219/new/

https://reviews.llvm.org/D142219



More information about the llvm-commits mailing list