[PATCH] D139130: InstCombine: Fold and (fcmp), (is.fpclass) into is.fpclass

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:1349
+      // fcmp uge fabs(x), +inf -> ~fcFinite
+      // fcmp olt x, +inf -> fcNegInf|fcSubnormal|fcNormal|fcZero
+      // fcmp uge x, +inf -> ~(fcFinite|fcNegInf)
----------------
arsenm wrote:
> foad wrote:
> > Simpler to write this as `fcFinite|fcNegInf`, as on the line below.
> Not sure where this comment is pointing anymore
Line 1339 in the current patch. I left a later comment saying the same thing with suggested diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139130/new/

https://reviews.llvm.org/D139130