[PATCH] D143359: [mlgo][regalloc] Handle training case when no regalloc happens.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 09:50:07 PST 2023


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/MLRegallocEvictAdvisor.cpp:477
                          llvm::function_ref<float()> GetReward) override {
-    if (!Log)
+    if (!Log || !Log->hasAnyObservationForContext(MF.getName()))
       return;
----------------
Ah, I see now, why things didn't work for me when I just moved the existing check :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143359/new/

https://reviews.llvm.org/D143359



More information about the llvm-commits mailing list