[PATCH] D141984: [RISCV][MC] Add support for experimental zfa extension(FLI instruction not included)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/test/MC/RISCV/rv32zfa-only-valid.s:6
+# RUN:     | FileCheck --check-prefix=CHECK-ASM-AND-OBJ %s
+
+# CHECK-ASM-AND-OBJ: fmvh.x.d a1, fs1
----------------
Add CHECK-NO-EXT  here too


================
Comment at: llvm/test/MC/RISCV/zfa-valid.s:12
+#
+# RUN: not llvm-mc -triple riscv32 -mattr=+d,+zfh \
+# RUN:     -riscv-no-aliases -show-encoding < %s 2>&1 \
----------------
If we remove the +d and +zfh here do we get error messages that mention all of the required extensions? I want to make sure we check that the .h instructions require zfh and zfa. Same for .d


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141984/new/

https://reviews.llvm.org/D141984