[PATCH] D141984: [RISCV][MC] Add support for experimental zfa extension(FLI instruction not included)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfa.td:67
+
+  let Predicates = [HasStdExtD] in {
+  def FMINM_D: FPALU_rr<0b0010101, 0b010, "fminm.d", FPR64, /*Commutable*/ 1>;
----------------
joshua-arch1 wrote:
> craig.topper wrote:
> > Lists in nested let statements don't concatenate. This list  needs to be [HasStdExtD, HasStdExtZfa]
> So I'm wondering if we should use nested format as @reames mentioned in the last comment. I guess lists in order will be better.
Yeah lists in order will be better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141984/new/

https://reviews.llvm.org/D141984