[PATCH] D143612: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++`

Argyrios Kyrtzidis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 15:48:27 PST 2023


akyrtzi added a comment.

In D143612#4114178 <https://reviews.llvm.org/D143612#4114178>, @benlangmuir wrote:

> I think we should verify the performance impact to running tests is minimal before landing this, like they did with the `_GLIBCXX_ASSERTIONS` change.

It isn't scientific but I did one timing of running the llvm & clang tests before this change and one timing running them after, and after took a bit less time, so probably this is lost in the noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143612/new/

https://reviews.llvm.org/D143612



More information about the llvm-commits mailing list