[PATCH] D143612: [CMake] Use `LLVM_ENABLE_ASSERTIONS` to enable assertions in `libc++`

Ben Langmuir via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 15:42:31 PST 2023


benlangmuir added a subscriber: ldionne.
benlangmuir added a comment.

I think we should verify the performance impact to running tests is minimal before landing this, like they did with the `_GLIBCXX_ASSERTIONS` change.  Also CCing @ldionne in case he has opinions on us using libc++ assertions.  Otherwise LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143612/new/

https://reviews.llvm.org/D143612



More information about the llvm-commits mailing list