[PATCH] D142084: [X86][MemFold] Upgrade the mechanism of auto-generated Memory Folding Table

Wed Feb 8 06:29:38 PST 2023

skan added inline comments.

================
Comment at: llvm/lib/Target/X86/X86MemFoldTables.inc:261
   {X86::JMP64r_NT, X86::JMP64m_NT, TB_FOLDED_LOAD},
+  {X86::JMP64r_REX, X86::JMP64m_REX, TB_FOLDED_LOAD},
   {X86::MMX_MOVD64from64rr, X86::MMX_MOVQ64mr, TB_FOLDED_STORE},
----------------
RKSimon wrote:
> It would be good to get some/all of these diffs committed first to minimize any changes in codegen due to this patch - the patch should only be about the build process.
Both methods are okay to me. I suggested the author to merge the table change into this PR b/c we are not confident the update in the table is correct. The new table needs a careful review.

And if the reviewer doubted an entry was incorrect, the author could point out which rule used in the X86FoldTablesEmitter.cpp was "guilty" and get suggestion/feedback from reviewers.

A separate diff would be the best way if we could check the correctness of the table just by looking at the entry themselves. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142084/new/

https://reviews.llvm.org/D142084