[PATCH] D141189: [Mips] Set setMaxAtomicSizeInBitsSupported

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 21:41:47 PST 2023


efriedma added a comment.

Makes sense to me.

For MIPS 1, we have essentially two choices: either we use `setMaxAtomicSizeInBitsSupported(0)`, and generate `__atomic_*` calls, or we set `setMaxAtomicSizeInBitsSupported(32)`, and generate native load/store with `__sync_*` calls for cmpxchg/atomicrmw.  Either way, we can't actually provide implementations; the user has to make it work somehow.  See D137980 <https://reviews.llvm.org/D137980> for a similar discussion... but generating `__sync_*` calls seems to cause less trouble.  (Not sure if anyone cares about MIPS 1 these days, though.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141189/new/

https://reviews.llvm.org/D141189



More information about the llvm-commits mailing list