[PATCH] D143516: [lit] [PATCH 1/2] Specify a common interface in a common base class for all report types

[Julian Lettner via Phabricator via llvm-commits]

yln accepted this revision.
yln added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

- 1 whitespace nit
- `abc` package available everywhere?  If not, can we do without?



================
Comment at: llvm/utils/lit/lit/reports.py:1
+import abc
 import base64
----------------
Please make sure this is a "default" Python package.  Otherwise it might not be available in every environment lit runs.


================
Comment at: llvm/utils/lit/lit/reports.py:10
 
-
 def by_suite_and_test_path(test):
----------------
Python lint says top level elements should be separated by 2 lines *shrug*


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143516/new/

https://reviews.llvm.org/D143516