[PATCH] D143475: [AArch64] Fix creation of invalid instructions with XZR register
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 7 12:15:23 PST 2023
efriedma added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp:326
+ MI.getOperand(1).getReg() == AArch64::WZR)
+ return false;
+
----------------
Is the transform assuming that the immediate is on the RHS (operand index 2)? If so, could you update the comment describing the transform to note that explicitly? Otherwise, it isn't really clear why operand index 1 is special.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143475/new/
https://reviews.llvm.org/D143475
More information about the llvm-commits
mailing list