[PATCH] D143506: [AArch64] Fix LSE2/LSE128/RCPC3 precedence

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 08:36:19 PST 2023


tmatheson created this revision.
tmatheson added reviewers: pratlucas, lenary, efriedma.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
tmatheson requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

D142712 <https://reviews.llvm.org/D142712> added tests for when both lse2 and lse128 are available, but
in practice there is no way to enable LSE128 without LSE2 from clang:
LSE128 is a v9 only feature and LSE2 has been mandatory since v8.4,
and +/-lse2 can not be specified on the clang command line.

Therefore it makes more sense that lse2+lse128 should emit lse128
instructions, otherwise they will not be emitted at all.

It also makes sense to remove the lse128-only backend tests if that set
of attributes is never set by the frontend.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143506

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomic-load-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomic-store-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomic-store-lse2_lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-atomicrmw-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-cmpxchg-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64-fence.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomic-load-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomic-store-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomic-store-lse2_lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64_be-atomicrmw-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64_be-cmpxchg-lse128.ll
  llvm/test/CodeGen/AArch64/Atomics/aarch64_be-fence.ll
  llvm/test/CodeGen/AArch64/Atomics/generate-tests.py



More information about the llvm-commits mailing list