[PATCH] D143487: [IR] Allow destruction of symbol table entries regardless of DiscardValueNames

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 04:58:47 PST 2023


yrouban added a comment.

In D143487#4109813 <https://reviews.llvm.org/D143487#4109813>, @arsenm wrote:

> This is only an issue if shouldDiscardValueNames() changes mid-compilation? What’s the use case for that?

We use one context for many subsequent compilations. Modules are removed and created as needed. In product mode DiscardValueNames are set to false. Sometimes we inject code using parseAssemblyString(), for this we have to set DiscardValueNames to true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143487/new/

https://reviews.llvm.org/D143487



More information about the llvm-commits mailing list