[PATCH] D143487: [IR] Allow destruction of symbol table entries regardless of DiscardValueNames

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

This is only an issue if shouldDiscardValueNames() changes mid-compilation? What’s the use case for that?



================
Comment at: llvm/unittests/IR/BasicBlockTest.cpp:551
+    auto M = parseAssemblyString(ModuleString, Err, Ctx);
+    EXPECT_TRUE(M.get());
+    EXPECT_FALSE(Ctx.shouldDiscardValueNames());
----------------
This needs to be ASSERT_


================
Comment at: llvm/unittests/IR/BasicBlockTest.cpp:556
+    auto M = parseAssemblyString(ModuleString, Err, Ctx);
+    EXPECT_TRUE(M.get());
+    Ctx.setDiscardValueNames(true);
----------------
Ditto 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143487/new/

https://reviews.llvm.org/D143487