[PATCH] D143085: [BOLT] Search section based on relocation symbol

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 marked 2 inline comments as done.
yota9 added inline comments.


================
Comment at: bolt/test/AArch64/array_end.c:31-32
+// REQUIRES: system-linux
+// RUN: %clang %cflags -no-pie %s -o %t.exe -Wl,-q \
+// RUN:   -Wl,-T %S/Inputs/array_end.ld_script
+// RUN: llvm-bolt %t.exe -o %t.bolt --print-disasm \
----------------
rafauler wrote:
> Is it possible to prune the script to only the relevant lines that trigger the problematic behavior?
> 
Sure, I was thinking to check  __init_array_end symboll too, but there is a problem that bolt creates symbols using address only without respecting section belonging. E.g __init_array_end symbol address == __fini_array_start , so on disassemble we might get wrong symbol names. It is not currently a big issue, but in case we would move (in this exmaple) fini_array section separately from init_array - it might be the problem. Just you to know, but it is out of scope of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143085/new/

https://reviews.llvm.org/D143085