[PATCH] D143085: [BOLT] Search section based on relocation symbol

[Rafael Auler via Phabricator via llvm-commits]

rafauler added a comment.

Thanks for the fix! Overall looks good, just a question on the test itself



================
Comment at: bolt/test/AArch64/array_end.c:30
+
+// REQUIRES: system-linux
+// RUN: %clang %cflags -no-pie %s -o %t.exe -Wl,-q \
----------------
Could you move REQUIRES, RUN, CHECK line to line 5, at the top of this file, for consistency with other checks?


================
Comment at: bolt/test/AArch64/array_end.c:31-32
+// REQUIRES: system-linux
+// RUN: %clang %cflags -no-pie %s -o %t.exe -Wl,-q \
+// RUN:   -Wl,-T %S/Inputs/array_end.ld_script
+// RUN: llvm-bolt %t.exe -o %t.bolt --print-disasm \
----------------
Is it possible to prune the script to only the relevant lines that trigger the problematic behavior?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143085/new/

https://reviews.llvm.org/D143085