[PATCH] D142839: [AMDGPU] Avoid using tuple where pair does suffice

Mauro Rossi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 6 11:40:49 PST 2023


maurossi updated this revision to Diff 495227.
maurossi added a comment.

Diff updated for conformance with git-clang-format


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142839/new/

https://reviews.llvm.org/D142839

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp


Index: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
+++ llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
@@ -5487,10 +5487,10 @@
   const char *AssemblerDirectiveEnd;
   std::tie(AssemblerDirectiveBegin, AssemblerDirectiveEnd) =
       isHsaAbiVersion3AndAbove(&getSTI())
-          ? std::tuple(HSAMD::V3::AssemblerDirectiveBegin,
-                       HSAMD::V3::AssemblerDirectiveEnd)
-          : std::tuple(HSAMD::AssemblerDirectiveBegin,
-                       HSAMD::AssemblerDirectiveEnd);
+          ? std::pair(HSAMD::V3::AssemblerDirectiveBegin,
+                      HSAMD::V3::AssemblerDirectiveEnd)
+          : std::pair(HSAMD::AssemblerDirectiveBegin,
+                      HSAMD::AssemblerDirectiveEnd);
 
   if (getSTI().getTargetTriple().getOS() != Triple::AMDHSA) {
     return Error(getLoc(),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142839.495227.patch
Type: text/x-patch
Size: 956 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230206/95b0bc4d/attachment.bin>


More information about the llvm-commits mailing list